add auto-fix API - Githubissues

dlang-community / D-Scanner

Swiss-army knife for D source code

Boost Software License 1.0

240 stars 80 forks source link

Closed WebFreak001 closed 1 year ago

WebFreak001 commented 1 year ago

fix #351

The error emission side can use this quite trivially, as shown in the diffs.

TODO: (this or future PRs)

[x] add CLI interface to interactively apply to issues (dscanner fix source/)
[x] expose IDE API over CLI
[x] make autofixes whitespace aware (test implementation in serve-d right now)
- [x] collapse neighboring whitespace in edits
- [x] add indent/dedent APIs (need to be aware of format settings)
[x] add unittests

Samples:

2023-07-06-01-49-16 2023-07-06-01-49-40 2023-07-06-01-49-49 2023-07-06-01-51-32 2023-07-06-01-52-35 2023-07-06-01-53-31

rikkimax commented 1 year ago

Wouldn't this be more appropriate for dfix instead?

WebFreak001 commented 1 year ago

no, we would need to duplicate all the logic for finding the issues to dfix as well.

Additionally I think it would be better to move the dfix fixes into D-Scanner instead and deprecated dfix.

WebFreak001 commented 1 year ago

did a basic self review and improved code quality, rebased commits to be better on them own.