search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

remove redundant implicit_2 #155

Closed Herringway closed 6 years ago

Herringway commented 6 years ago

There is no value in the implicit argument for scalarEvent being a tuple. This isn't a tuple anywhere else in the code.

codecov[bot] commented 6 years ago

Codecov Report

Merging #155 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   93.34%   93.34%   -0.01%     
==========================================
  Files          31       31              
  Lines        4314     4310       -4     
==========================================
- Hits         4027     4023       -4     
  Misses        287      287
Impacted Files Coverage Δ
source/dyaml/serializer.d 95.71% <ø> (-0.12%) :arrow_down:
source/dyaml/parser.d 97.71% <100%> (-0.01%) :arrow_down:
source/dyaml/test/emitter.d 93.93% <100%> (ø) :arrow_up:
source/dyaml/event.d 98.11% <100%> (-0.04%) :arrow_down:
source/dyaml/emitter.d 94.47% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32605c8...9420260. Read the comment docs.

Herringway commented 6 years ago

The comments say it's from PyYAML, but it doesn't seem like it ever existed there. And as far as I can tell, it's totally redundant here. It should probably just be removed...

Herringway commented 6 years ago

Done. Bonus: slight speedup!