dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

partially address D-Scanner warnings in the whole project #170

Closed ghost closed 6 years ago

ghost commented 6 years ago

Mostly trivial excepted that the signature of a function changes (Scanner.scanPlainSpacesToSlice).

codecov[bot] commented 6 years ago

Codecov Report

Merging #170 into master will decrease coverage by 0.02%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   93.38%   93.36%   -0.03%     
==========================================
  Files          31       31              
  Lines        4340     4338       -2     
==========================================
- Hits         4053     4050       -3     
- Misses        287      288       +1
Impacted Files Coverage Δ
source/dyaml/dumper.d 89.47% <ø> (ø) :arrow_up:
source/dyaml/test/emitter.d 93.93% <100%> (ø) :arrow_up:
source/dyaml/loader.d 90.9% <100%> (ø) :arrow_up:
source/dyaml/constructor.d 89.26% <100%> (ø) :arrow_up:
source/dyaml/parser.d 97.73% <100%> (ø) :arrow_up:
source/dyaml/test/common.d 83.67% <100%> (-0.33%) :arrow_down:
source/dyaml/test/constructor.d 97.27% <100%> (ø) :arrow_up:
source/dyaml/serializer.d 95.71% <100%> (ø) :arrow_up:
source/dyaml/scanner.d 97.84% <100%> (ø) :arrow_up:
source/dyaml/reader.d 97.97% <100%> (ø) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update deb5641...09fe112. Read the comment docs.

Herringway commented 6 years ago

Looks fine to me. The mark argument is only used for errors and there are no possible error states for this one.