dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

Implement range interface for Loader, remove old opApply interface #196

Closed Herringway closed 6 years ago

Herringway commented 6 years ago

opApply sucks. let's kill it

Herringway commented 6 years ago

Not sure whether or not the version should be bumped with this. it's technically a changed interface, but old code should still work

codecov[bot] commented 6 years ago

Codecov Report

Merging #196 into master will decrease coverage by 0.03%. The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   93.85%   93.81%   -0.04%     
==========================================
  Files          29       29              
  Lines        4313     4303      -10     
==========================================
- Hits         4048     4037      -11     
- Misses        265      266       +1
Impacted Files Coverage Δ
source/dyaml/composer.d 96.46% <ø> (-0.21%) :arrow_down:
source/dyaml/test/representer.d 96.29% <100%> (ø) :arrow_up:
source/dyaml/test/compare.d 91.66% <100%> (ø) :arrow_up:
source/dyaml/test/errors.d 81.81% <100%> (ø) :arrow_up:
source/dyaml/loader.d 89.15% <90.47%> (-1.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a40574...6631fb0. Read the comment docs.

ghost commented 6 years ago

The question with tags and DUB is rather if the patch or the minor part of the tag has to be changed.

But as long as no tag is pushed there's no problem at all. Put this in the 0.8 milestone seems wise and safe.