search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

fix #205 by removing useless assertions about `Value` and `Node` sizes #206

Closed ghost closed 5 years ago

ghost commented 5 years ago

Since Value is based on a Variant there's really no reason for which its size in memory would become unexpectedly huge.

codecov[bot] commented 5 years ago

Codecov Report

Merging #206 into master will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   93.78%   93.66%   -0.12%     
==========================================
  Files          28       28              
  Lines        4279     4201      -78     
==========================================
- Hits         4013     3935      -78     
  Misses        266      266
Impacted Files Coverage Δ
source/dyaml/node.d 93.42% <ø> (-0.08%) :arrow_down:
source/dyaml/representer.d 77.13% <0%> (-1.17%) :arrow_down:
source/dyaml/constructor.d 88.48% <0%> (-0.79%) :arrow_down:
source/dyaml/test/common.d 83.33% <0%> (-0.35%) :arrow_down:
source/dyaml/test/representer.d 96.15% <0%> (-0.15%) :arrow_down:
source/dyaml/loader.d 89.02% <0%> (-0.14%) :arrow_down:
source/dyaml/test/constructor.d 97.14% <0%> (-0.13%) :arrow_down:
source/dyaml/resolver.d 94.44% <0%> (-0.11%) :arrow_down:
source/dyaml/emitter.d 93.18% <0%> (-0.06%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dbec8d...43244be. Read the comment docs.