search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

make node types into enums and clean up code using them #225

Closed Herringway closed 5 years ago

Herringway commented 5 years ago

Closes #224.

I don't know if we'll ever have to add new members to the enums, but we'll know where we need to make changes immediately now that there are final switches all over the place.

Herringway commented 5 years ago

I don't really like the name nodeID but type is already used.

codecov[bot] commented 5 years ago

Codecov Report

Merging #225 into master will decrease coverage by 0.38%. The diff coverage is 83.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   95.21%   94.82%   -0.39%     
==========================================
  Files          28       28              
  Lines        4160     4253      +93     
==========================================
+ Hits         3961     4033      +72     
- Misses        199      220      +21
Impacted Files Coverage Δ
source/dyaml/test/resolver.d 76.92% <100%> (ø) :arrow_up:
source/dyaml/constructor.d 92.01% <100%> (ø) :arrow_up:
source/dyaml/node.d 92.45% <80.3%> (-1.53%) :arrow_down:
source/dyaml/composer.d 95.86% <86.95%> (-0.6%) :arrow_down:
source/dyaml/representer.d 98.48% <87.5%> (-0.47%) :arrow_down:
source/dyaml/serializer.d 94.68% <92.98%> (-1.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d83c6a...3907c1e. Read the comment docs.