search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

reimplement isPrintableValidUTF8 using phobos functions #235

Closed Herringway closed 5 years ago

Herringway commented 5 years ago

Much cleaner, but comes with a performance penalty...

codecov[bot] commented 5 years ago

Codecov Report

Merging #235 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   94.86%   94.86%   +<.01%     
==========================================
  Files          28       28              
  Lines        4266     4229      -37     
==========================================
- Hits         4047     4012      -35     
+ Misses        219      217       -2
Impacted Files Coverage Δ
source/dyaml/reader.d 98.43% <100%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8de1a45...ff38f20. Read the comment docs.