search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

remove pointless Composer destructor #238

Closed Herringway closed 5 years ago

Herringway commented 5 years ago

The order in which destructors are called is undefined, so it's possible that we're wasting time destroying already-destroyed things here. It's also not necessary, so let's just remove it.

codecov[bot] commented 5 years ago

Codecov Report

Merging #238 into master will decrease coverage by <.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage    94.9%   94.89%   -0.01%     
==========================================
  Files          28       28              
  Lines        4256     4253       -3     
==========================================
- Hits         4039     4036       -3     
  Misses        217      217
Impacted Files Coverage Δ
source/dyaml/composer.d 95.72% <ø> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 942c353...a68a2d1. Read the comment docs.