dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

Some Exception-related fixes #241

Closed Herringway closed 5 years ago

Herringway commented 5 years ago

Just some cleanup related to exception handling.

codecov[bot] commented 5 years ago

Codecov Report

Merging #241 into master will decrease coverage by <.01%. The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   94.89%   94.89%   -0.01%     
==========================================
  Files          28       28              
  Lines        4254     4191      -63     
==========================================
- Hits         4037     3977      -60     
+ Misses        217      214       -3
Impacted Files Coverage Δ
source/dyaml/node.d 92.45% <100%> (ø) :arrow_up:
source/dyaml/reader.d 97.94% <100%> (ø) :arrow_up:
source/dyaml/constructor.d 92.01% <100%> (ø) :arrow_up:
source/dyaml/scanner.d 99.32% <95.23%> (+0.7%) :arrow_up:
source/dyaml/exception.d 86.66% <0%> (-13.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11020e4...5d7324a. Read the comment docs.

Herringway commented 5 years ago

Some of the logic in Scanner was painfully convoluted because of that error handling... am really glad to delete it here