search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

undo some false optimizations #252

Closed Herringway closed 4 years ago

Herringway commented 4 years ago

I'm not sure why these were even done in the first place. I did not see any significant performance difference in any of the compilers I tested, both with and without -O...

Much easier to read this code now.

codecov[bot] commented 4 years ago

Codecov Report

Merging #252 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   94.97%   94.98%           
=======================================
  Files          28       28           
  Lines        4139     4126   -13     
=======================================
- Hits         3931     3919   -12     
+ Misses        208      207    -1
Impacted Files Coverage Δ
source/dyaml/scanner.d 99.48% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50372b1...b61d043. Read the comment docs.