dlang-community / D-YAML

YAML parser and emitter for the D programming language

https://dlang-community.github.io/D-YAML/

Boost Software License 1.0

119 stars 37 forks source link

fix(ci/yaml-test-suite): Update path to yaml-test-suite test cases #277

Closed PetarKirov closed 3 years ago

PetarKirov commented 3 years ago

A recent PR to yaml-test-suite moved the test cases from test/ to src/ and broke our CI pipeline.

This commit resolves #276.

codecov[bot] commented 3 years ago

Codecov Report

Merging #277 (d13c984) into master (8d48caf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          28       28           
  Lines        4066     4066           
=======================================
  Hits         3903     3903           
  Misses        163      163

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef96ff4...d13c984. Read the comment docs.

Herringway commented 3 years ago

while this does technically resolve it, it's now not running any tests... but that's acceptable since the actual results of the tests aren't being used yet

will need to add support for the new test format eventually, I guess.

PetarKirov commented 3 years ago

Hmm, I have missed the most important reason for the test.. please excuse me for not waiting for a proper review! I just thought it was a trivial matter.

Herringway commented 3 years ago

it's mostly just informative right now, since the test suite is for a YAML version we don't yet support. we don't actually require those tests to pass, just for the runner to successfully execute