search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

Refactor some `Node.opCmp` code #295

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

I believe the new code is a bit more readable (/verbose)

Herringway commented 2 years ago

it's certainly more readable, but the tests are failing

Geod24 commented 2 years ago

Fixed

codecov[bot] commented 2 years ago

Codecov Report

Merging #295 (dd01d82) into master (85f3d1d) will decrease coverage by 0.02%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   95.43%   95.41%   -0.03%     
==========================================
  Files          28       28              
  Lines        4100     4103       +3     
==========================================
+ Hits         3913     3915       +2     
- Misses        187      188       +1
Impacted Files Coverage Δ
source/dyaml/node.d 91.05% <91.66%> (-0.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85f3d1d...dd01d82. Read the comment docs.