search

dlang-community / D-YAML

YAML parser and emitter for the D programming language
https://dlang-community.github.io/D-YAML/
Boost Software License 1.0
119 stars 37 forks source link

make sure assertEventsEqual() actually has events to test #316

Closed Herringway closed 1 year ago

Herringway commented 1 year ago

Turns out a big portion of the test suite wasn't actually running due to Loader.parse() not returning a forward range. Note that the test suite now fails, so this probably shouldn't be merged just yet....

codecov[bot] commented 1 year ago

Codecov Report

Merging #316 (5e0bdad) into master (05cdebf) will increase coverage by 0.15%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316/graphs/tree.svg?width=650&height=150&src=pr&token=3GhqwvvAYo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community)](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) ```diff @@ Coverage Diff @@ ## master #316 +/- ## ========================================== + Coverage 95.13% 95.29% +0.15% ========================================== Files 29 29 Lines 4505 4505 ========================================== + Hits 4286 4293 +7 + Misses 219 212 -7 ``` | [Files Changed](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) | Coverage Δ | | |---|---|---| | [source/dyaml/test/emitter.d](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c291cmNlL2R5YW1sL3Rlc3QvZW1pdHRlci5k) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Last update [05cdebf...5e0bdad](https://app.codecov.io/gh/dlang-community/D-YAML/pull/316?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community).