Closed ryuukk closed 1 year ago
✅ This PR fixes following deprecations:
common/src/dcd/common/messages.d(264,3): Deprecation: `return` statements cannot be in `scope(failure)` bodies.
common/src/dcd/common/messages.d(264,3): Deprecation: `return` statements cannot be in `scope(failure)` bodies.
../../../.dub/packages/msgpack-d-1.0.4/msgpack-d/src/msgpack/unpacker.d(18,26): Deprecation: using `in` parameters with `extern(C)` functions is deprecated
common/src/dcd/common/messages.d(264,3): Deprecation: `return` statements cannot be in `scope(failure)` bodies.
Total deprecations: 104
Total warnings: 4
Build statistics:
statistics (-before, +after)
client size=1055680 bin/dcd-client
-server size=2970776 bin/dcd-server
-rough build time=77s
+server size=2974936 bin/dcd-server
+rough build time=78s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.91
-DCD run_tests.sh Maximum resident set size (kbytes): 42912
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.84
+DCD run_tests.sh Maximum resident set size (kbytes): 41692
short requests: (228x)
- min request time = 0.010ms
- 10th percentile = 0.135ms
- median time = 0.491ms
- 90th percentile = 0.810ms
- max request time = 1.776ms
+ min request time = 0.019ms
+ 10th percentile = 0.127ms
+ median time = 0.461ms
+ 90th percentile = 0.788ms
+ max request time = 1.670ms
long requests over 10ms: (51x)
- min request time = 21.500ms
- 10th percentile = 23.348ms
- median time = 24.651ms
- 90th percentile = 27.049ms
- max request time = 32.805ms
+ min request time = 21.046ms
+ 10th percentile = 22.857ms
+ median time = 24.948ms
+ 90th percentile = 27.170ms
+ max request time = 33.017ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
- 88396800 843 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
+ 84673536 863 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
14241024 163616 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.104.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9770656 305333 std.array.Appender!(immutable(char)[]).Appender.Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.104.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371104 279 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../.dub/packages/msgpack-d-1.0.4/msgpack-d/src/msgpack/common.d:628
7101600 5918 immutable(char)[][immutable(char)[]] dsymbol.ufcs.typeWillBeUpcastedTo dsymbol/src/dsymbol/ufcs.d:292
This code logic is dumb, it should be greatly simplified, i'll try to do it in a different PR, let's just this deprecation warning first