Open ryuukk opened 10 months ago
DCD BUILD FAILED
❌ Basic dub build
failed! Please check your changes again.
Build statistics:
statistics (-before, +after)
client size=1052640 bin/dcd-client
-server size=3102400 bin/dcd-server
-rough build time=62s
+server size=3102208 bin/dcd-server
+rough build time=64s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.86
-DCD run_tests.sh Maximum resident set size (kbytes): 40808
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.08
+DCD run_tests.sh Maximum resident set size (kbytes): 36436
short requests: (240x)
- min request time = 0.007ms
- 10th percentile = 0.166ms
- median time = 0.347ms
- 90th percentile = 0.602ms
- max request time = 1.643ms
+ min request time = 0.012ms
+ 10th percentile = 0.188ms
+ median time = 0.386ms
+ 90th percentile = 0.655ms
+ max request time = 1.479ms
long requests over 10ms: (51x)
- min request time = 11.653ms
- 10th percentile = 12.431ms
- median time = 14.441ms
- 90th percentile = 15.469ms
- max request time = 21.600ms
+ min request time = 13.103ms
+ 10th percentile = 13.980ms
+ median time = 16.545ms
+ 90th percentile = 18.367ms
+ max request time = 22.940ms
top 5 GC sources in server:
that github action is weird, ans is showing the escape code, perhaps need to disable colors
the github action regressed with a dmd update, profilegc is broken again, so while that is broken upstream we can't rely on the comment action
Looks better:
Code could be greatly improved, i wanted to submit the PR before going to bed, i'll revise tomorrow
Quick Edit:
Ideally that shouldn't be needed in that place
It should be done in
first.d
, a proper callTip should be built in theprocessTemplateParameters
function, so it'd support template params that are also templates, but i am too lazy