Open ryuukk opened 4 months ago
DCD BUILD FAILED
DCD BUILD FAILED
❌ Basic dub build
failed! Please check your changes again.
Build statistics:
statistics (-before, +after)
client size=1079792 bin/dcd-client
-server size=3108616 bin/dcd-server
-rough build time=60s
+server size=
+rough build time=51s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.88
-DCD run_tests.sh Maximum resident set size (kbytes): 37244
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:00.00
+DCD run_tests.sh Maximum resident set size (kbytes): 768
-short requests: (240x)
- min request time = 0.012ms
- 10th percentile = 0.152ms
- median time = 0.363ms
- 90th percentile = 0.620ms
- max request time = 1.508ms
-long requests over 10ms: (51x)
- min request time = 11.632ms
- 10th percentile = 12.840ms
- median time = 14.521ms
- 90th percentile = 16.329ms
- max request time = 23.446ms
top 5 GC sources in server:
Build fail because i have introduced a new field to DSymbol: location_end
, to keep track of scopes, making it easier to implement sticky scroll / outline features
I'll send a separate PR for that
Alternative approach to this: https://github.com/Pure-D/serve-d/blob/master/dcd/source/served/dcd/client.d
On Wed, 10 Jul 2024, 21:26 ryuukk, @.***> wrote:
Tests fail because i have introduced a new field to DSymbol: location_end, to keep track of scopes, making it easier to implement sticky scroll / outline features
image.png (view on web) https://github.com/dlang-community/DCD/assets/44361234/5178d85d-9127-4ef3-8c20-ecac5a04fc21
— Reply to this email directly, view it on GitHub https://github.com/dlang-community/DCD/pull/777#issuecomment-2220001917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSL46XRUBPEOY3FJAVTUTZLT427AVCNFSM6AAAAABKUPWD36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGAYDCOJRG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>
No this is just bad, you still need to spawn dcd-server
, and you still need to spawn dcd-client
for every requests, this is both slow and complex
This allows using DCD as a library, useful for making tooling
I have a proof of concept of a simple LSP that uses DCD as a library, making its lifecycle much simpler, no need to spawn/track bunch of processes
This is just a draft for now, i'm seeking feedback/opinions