search

dlang-community / Pegged

A Parsing Expression Grammar (PEG) module, using the D programming language.
534 stars 66 forks source link

pegged.peg.ParseTree.failMsg seems unused and redundant #133

Closed timotheecour closed 4 years ago

timotheecour commented 10 years ago

Seems like failMsg is unused and uses a lot of same code as toString so at least would be nice to refactor a bit

PhilippeSigaud commented 10 years ago

You're right. I'm astonished to have such a code. I tend to factor common parts quite heavily. Damn, I haven't used github in quite a while. I'm not even sure my new computer have the good access keys. Oh well...

etcimon commented 10 years ago

What have you been up to? I use a a lot of what you've done as learning material

timotheecour commented 10 years ago

hmmm, are you still working on pegged (ie accepting pull requests and working on improvements)? I have a few concrete ideas for improvements.

PhilippeSigaud commented 10 years ago

On Mon, Jun 9, 2014 at 1:06 AM, Timothee Cour notifications@github.com wrote:

hmmm, are you still working on pegged (ie accepting pull requests and working on improvements)?

I'm still accepting pull requests! I always try to merge them rapidly.

I have a few concrete ideas for improvements.

Please send them! I'll gladly integrate them into the codebase.

PhilippeSigaud commented 10 years ago

On Sun, Jun 8, 2014 at 11:35 PM, Etienne Cimon notifications@github.com wrote:

What have you been up to? I use a a lot of what you've done as learning material

Thanks! I'm just having a hefty dose of real life: three children, a rewarding but demanding job, moving houses and hitting 40 all makes life suddenly quite overcrowded and free time a rare treat :)