dlang-community / Pegged

A Parsing Expression Grammar (PEG) module, using the D programming language.
534 stars 66 forks source link

[refactor] Add a default value to 'parseArithmetic' in the arithmetic example grammar #317

Closed iK4tsu closed 1 year ago

iK4tsu commented 1 year ago

By adding a default value, there's no longer the need to have an overloaded function. Since the function never modifies the original AA, there's no need for it to be passed by reference either.

veelo commented 1 year ago

Thanks a lot!

iK4tsu commented 1 year ago

@veelo btw could you add the hacktoberfest-accepted label?

veelo commented 1 year ago

@veelo btw could you add the hacktoberfest-accepted label?

I'll have to create one. Do you have a preferred color?

iK4tsu commented 1 year ago

Not really, can be whatever you prefer. Thank you! :smile:

ljmf00-wekaio commented 1 year ago

@veelo btw could you add the hacktoberfest-accepted label?

I'll have to create one. Do you have a preferred color?

You can add hacktoberfest tag on the repo, so you don't need to add this label on every PR :)

veelo commented 1 year ago

You can add hacktoberfest tag on the repo, so you don't need to add this label on every PR :)

I have looked for that option, but I'm just a maintainer, and I think you have to be owner for that.