refactor(peg): ease dip1000 changes

dlang-community / Pegged

A Parsing Expression Grammar (PEG) module, using the D programming language.

534 stars 66 forks source link

Closed iK4tsu closed 1 year ago

iK4tsu commented 1 year ago

@ljmf00-wekaio as discussed in #322 , please review the changes

iK4tsu commented 1 year ago

the proposed cast solution by @dkorpel does not work at compile time
even with that workaround, the FIXMEs would need to stand until a fix gets released, I left them
removed the need for the @trusted lambda, since we're using .idup it isn't needed
removed the .idup added in getUpTo by iterating each index instead of passing the slice to it

veelo commented 1 year ago

@ljmf00-wekaio can I get your LGTM on this?

iK4tsu commented 1 year ago

update:

reverted: removed the .idup added in getUpTo by iterating each index instead of passing the slice to it

veelo commented 1 year ago

Thanks guys, I'll add -preview=dip1000 to CI tomorrow and tag a release.