search

dlang-community / d-money

Handling amounts of money safely and efficiently
Boost Software License 1.0
9 stars 3 forks source link

Coverage is displayed wrong #1

Closed qznc closed 4 years ago

qznc commented 4 years ago

The button currently shows 99% test coverage. However, the money.d file is covered 100%. It is some /tmp/dub_test_root_something.d file which is uncovered and somehow included for the statistics.

Maybe https://github.com/ColdenCullen/doveralls is outdated? Maybe https://codecov.io is an alternative?

qznc commented 4 years ago

@wilzbach any opinion how to report coverage well?

dlang-community/discussions#15 discusses this issue as well.

mw66 commented 4 years ago

Also I saw the version is bump to 3.0.0

https://github.com/dlang-community/d-money/releases/tag/v3.0.0

but dub still haven't picked it up?

https://code.dlang.org/packages/money

2.5.0 released 7 days ago

mw66 commented 4 years ago

$ dub upgrade

Unresolvable dependencies to package money: ats ~master depends on money ~>3.0.0

mw66 commented 4 years ago

Also even on github, the latest version is not showing:

https://github.com/dlang-community/d-money

it's showing dub v2.5.0

qznc commented 4 years ago

There seems to be a bigger issue with the registry: https://github.com/dlang/dub-registry/issues/462

mw66 commented 4 years ago

Maybe it's because of this d-money repo's setup issue?

I just saw on https://code.dlang.org/

The other package I reviewed showed up:

fixedpoint 0.1.1 Decimal fixed point type updated 17 minutes ago

But this package's update is not picked up.

wilzbach commented 4 years ago

@wilzbach any opinion how to report coverage well?

dlang-community/discussions#15 discusses this issue as well.

I made pretty good experience with CodeCov and we use it for the main DMD/Druntime/Phobos repositories. On Travis all you need to do is add:

after_success:
 - bash <(curl -s https://codecov.io/bash)

IIRC dub automatically adds coverage info on CI, but if not you can do e.g. dub test --coverage or DFLAGS="-cov" dub.

Codecov supports a few other options like e.g. excluding unwanted files from the report, which might also help to solve your problem. We use this feature at e.g. DMD: https://github.com/dlang/dmd/blob/master/.codecov.yml

qznc commented 4 years ago

Switched to codecov and issue is fixed.

I also added a grep command to the CI, so it fails now if coverage decreases.