Closed ShigekiKarita closed 4 years ago
@wilzbach I've rerun CI, you seem to have some ownership, are we good to go?
Sure. Sorry for missing it and thanks for the ping!
you seem to have some ownership
Should we change the teams to give everyone at dlang-community access to every repo?
you seem to have some ownership
Should we change the teams to give everyone at dlang-community access to every repo?
I was referring to the code base, rather than the repository. So no, we are good as far as I know :)
I found a unittest inside
Interpreter
template can cause compiler error when I built drepl with unittest or used as a library. The problem is comparison betweenInterpreter!EchoEngine.Kind
andInterpreter!(<Instantiated Type>).Kind
in the unittest.For example, when I instantiated
Interpreter!DMDEngine
inside unittest caused following compiler error.Therefore, I propose adding
static if
to limit the unittest instantiation only withEchoEngine
.