Closed Hackerpilot closed 1 year ago
Merging #436 (4f1fcb8) into master (776ca6b) will increase coverage by
0.04%
. The diff coverage is85.41%
.
D added support for that in master, should be merged before next version
cc @WebFreak001
thanks! This is gonna be quite an exciting change.
Further things on the roadmap:
Will review and adjust this PR
DCD BUILD FAILED
❌ dub build
of DCD has failed with these changes! Please check your changes again.
Build statistics:
------ libdparse statistics ------
statistics (-before, +after)
-library size=3511132 libdparse.a
+library size=3542452 libdparse.a
rough build time=16s
------ DCD statistics ------
statistics (-before, +after)
client size=1055768 bin/dcd-client
-server size=3018608 bin/dcd-server
+server size=3035696 bin/dcd-server
rough build time=76s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.90
-DCD run_tests.sh Maximum resident set size (kbytes): 9928
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.88
+DCD run_tests.sh Maximum resident set size (kbytes): 14096
-short requests: (219x)
- min request time = 0.009ms
- 10th percentile = 0.131ms
- median time = 0.448ms
- 90th percentile = 0.735ms
- max request time = 2.531ms
+short requests: (217x)
+ min request time = 0.008ms
+ 10th percentile = 0.134ms
+ median time = 0.436ms
+ 90th percentile = 0.738ms
+ max request time = 1.404ms
top 5 GC sources in server:
https://github.com/dlang/DIPs/blob/master/DIPs/accepted/DIP1030.md
The DIP mentions changing the definition of the
ArgumentList
rule, but that would cause problems in places such as case statements, mixins, index expression, and several others. I'll need to make sure that the pull request to the grammar spec is correct when it happens. A few other rules should be changed to use the newNamedArgumenList
, and others need to continue usingArgumentList
.