dlang-community / libdparse

Library for lexing and parsing D source code
https://libdparse.dlang.io
Boost Software License 1.0
114 stars 56 forks source link

implement bitfield parsing #476

Closed WebFreak001 closed 1 year ago

WebFreak001 commented 1 year ago

fixes #464

should get merged soon, because of new DMD release around the corner, so would like a quick review ^^

upstream DMD implementation: https://github.com/dlang/dmd/blob/a7f8c84d405df2c0dd8929d2479c1760f61762e0/compiler/src/dmd/parse.d#L4621

codecov[bot] commented 1 year ago

Codecov Report

Merging #476 (4be179e) into master (7348c5f) will increase coverage by 0.05%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/dlang-community/libdparse/pull/476/graphs/tree.svg?width=650&height=150&src=pr&token=VHoPCaUjPZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community)](https://codecov.io/gh/dlang-community/libdparse/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) ```diff @@ Coverage Diff @@ ## master #476 +/- ## ========================================== + Coverage 83.27% 83.33% +0.05% ========================================== Files 11 11 Lines 8378 8402 +24 ========================================== + Hits 6977 7002 +25 + Misses 1401 1400 -1 ``` | [Impacted Files](https://codecov.io/gh/dlang-community/libdparse/pull/476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) | Coverage Δ | | |---|---|---| | [src/dparse/ast.d](https://codecov.io/gh/dlang-community/libdparse/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c3JjL2RwYXJzZS9hc3QuZA==) | `70.83% <100.00%> (+0.23%)` | :arrow_up: | | [src/dparse/astprinter.d](https://codecov.io/gh/dlang-community/libdparse/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c3JjL2RwYXJzZS9hc3RwcmludGVyLmQ=) | `94.95% <100.00%> (+0.02%)` | :arrow_up: | | [src/dparse/formatter.d](https://codecov.io/gh/dlang-community/libdparse/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c3JjL2RwYXJzZS9mb3JtYXR0ZXIuZA==) | `46.46% <100.00%> (+0.47%)` | :arrow_up: | | [src/dparse/parser.d](https://codecov.io/gh/dlang-community/libdparse/pull/476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c3JjL2RwYXJzZS9wYXJzZXIuZA==) | `91.42% <100.00%> (+0.01%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/dlang-community/libdparse/pull/476?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/dlang-community/libdparse/pull/476?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Last update [7348c5f...4be179e](https://codecov.io/gh/dlang-community/libdparse/pull/476?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community).
WebFreak001 commented 1 year ago

gonna merge this because release is nearing (in 5 days)