Closed WebFreak001 closed 1 year ago
Merging #488 (df9c61e) into master (98bf0f4) will not change coverage. The diff coverage is
n/a
.
sample comment:
✅ PR OK, no changes in deprecations or warnings
Total deprecations: 0
Total warnings: 0
Build statistics:
------ libdparse statistics ------
statistics (-before, +after)
-library size=3432236 libdparse.a
-rough build time=19s
+library size=3432324 libdparse.a
+rough build time=18s
------ DCD statistics ------
statistics (-before, +after)
client size=1055768 bin/dcd-client
server size=3006064 bin/dcd-server
-rough build time=88s
+rough build time=89s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.90
-DCD run_tests.sh Maximum resident set size (kbytes): 13128
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.98
+DCD run_tests.sh Maximum resident set size (kbytes): 12304
short requests: (212x)
- min request time = 0.009ms
- 10th percentile = 0.137ms
- median time = 0.462ms
- 90th percentile = 0.880ms
- max request time = 1.934ms
+ min request time = 0.019ms
+ 10th percentile = 0.128ms
+ median time = 0.506ms
+ 90th percentile = 0.959ms
+ max request time = 2.041ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
7438336 454 void[] std.array.Appender!(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields; mixin TokenTriviaFields;")[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
7421824 80004 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
2277376 278 void[] std.array.Appender!(char[][]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
1798144 56192 std.array.Appender!(dsymbol.symbol.DSymbol*[]).Appender.Data std.array.Appender!(DSymbol*[]).Appender.this /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3452
- 1384448 590 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
+ 1462272 594 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
idea why I included DCD here:
the big auto-generated test for UFCS (https://github.com/dlang-community/DCD/pull/733) is currently heavily slowed down by libdparse parsing / AST + quite heavy in RAM usage. So I was thinking that it would be a good candidate to auto-test for RAM & CPU speed changes of everything in the chain, including libdparse (which is currently RAM user #1 in DCD)
I think the many details from DCD might be distracting here though. Thoughts?
I vouch for this, since Im generally in favor for more information for measuring performance.
analogous to https://github.com/dlang-community/DCD/pull/735
this clones current DCD master and runs its comment script & embeds the content here. This is because libdparse RAM/CPU improvements and general API changes will heavily affect long-running persistent processes such as dcd-server.