Open WebFreak001 opened 1 year ago
Merging #491 (ded6025) into master (f0b1f14) will decrease coverage by
0.26%
. The diff coverage is72.68%
.
Something about this not being faster smells to me. Usually, when you decrease RAM usage significantly, it should be much faster.
But otherwise, less ram usage the better!
DCD BUILD FAILED
❌ dub build
of DCD has failed with these changes! Please check your changes again.
Build statistics:
------ libdparse statistics ------
statistics (-before, +after)
-library size=3544204 libdparse.a
-rough build time=20s
+library size=3585740 libdparse.a
+rough build time=19s
------ DCD statistics ------
statistics (-before, +after)
client size=1055832 bin/dcd-client
-server size=3052720 bin/dcd-server
-rough build time=94s
+server size=3079792 bin/dcd-server
+rough build time=93s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.90
-DCD run_tests.sh Maximum resident set size (kbytes): 9300
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.98
+DCD run_tests.sh Maximum resident set size (kbytes): 12884
short requests: (217x)
min request time = 0.018ms
- 10th percentile = 0.138ms
- median time = 0.457ms
- 90th percentile = 0.755ms
- max request time = 2.184ms
+ 10th percentile = 0.136ms
+ median time = 0.488ms
+ 90th percentile = 0.855ms
+ max request time = 2.080ms
top 5 GC sources in server:
Depends on #490
Step 1/2 for #409
dcd-server peak RAM usage for one environment: 197 MB -> 130 MB (-33%)
CPU time about the same (ever so slightly lower, but could just be jitter)