dlang-community / libdparse

Library for lexing and parsing D source code
https://libdparse.dlang.io
Boost Software License 1.0
114 stars 56 forks source link

Fix shortened FunctionBody and comment formatting #512

Closed zyebytevt closed 6 months ago

zyebytevt commented 6 months ago

Nothing major, but the comment formatting produced invalid code since the three slashes at the beginning weren't written. Additionally, a shortened function body (=>) now also appears in formatting.

github-actions[bot] commented 6 months ago

DCD BUILD FAILED ❌ dub build of DCD has failed with these changes! Please check your changes again.

Build statistics:

 ------ libdparse statistics ------

 statistics (-before, +after)
-library size=3163068 libdparse.a
+library size=3170548 libdparse.a
 rough build time=13s

 ------ DCD statistics ------

 statistics (-before, +after)
 client size=1052640 bin/dcd-client
-server size=3110400 bin/dcd-server
+server size=3110848 bin/dcd-server
 rough build time=63s

-DCD run_tests.sh   Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.18
-DCD run_tests.sh   Maximum resident set size (kbytes): 41496
+DCD run_tests.sh   Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.95
+DCD run_tests.sh   Maximum resident set size (kbytes): 39664

 short requests: (240x)
-    min request time =     0.012ms
-    10th percentile  =     0.132ms
-    median time      =     0.424ms
-    90th percentile  =     0.707ms
-    max request time =     1.520ms
+    min request time =     0.010ms
+    10th percentile  =     0.135ms
+    median time      =     0.363ms
+    90th percentile  =     0.612ms
+    max request time =     1.503ms

 long requests over 10ms: (51x)
-    min request time =    13.219ms
-    10th percentile  =    15.143ms
-    median time      =    16.422ms
-    90th percentile  =    18.737ms
-    max request time =    22.406ms
+    min request time =    12.406ms
+    10th percentile  =    13.927ms
+    median time      =    14.738ms
+    90th percentile  =    16.568ms
+    max request time =    21.695ms

 top 5 GC sources in server:
Full build output ``` DUB version 1.34.0, built on Oct 15 2023 LDC - the LLVM D compiler (1.35.0): based on DMD v2.105.2 and LLVM 16.0.6 built with LDC - the LLVM D compiler (1.35.0) Default target: x86_64-unknown-linux-gnu Host CPU: znver3 http://dlang.org - http://wiki.dlang.org/LDC Registered Targets: aarch64 - AArch64 (little endian) aarch64_32 - AArch64 (little endian ILP32) aarch64_be - AArch64 (big endian) amdgcn - AMD GCN GPUs arm - ARM arm64 - ARM64 (little endian) arm64_32 - ARM64 (little endian ILP32) armeb - ARM (big endian) avr - Atmel AVR Microcontroller bpf - BPF (host endian) bpfeb - BPF (big endian) bpfel - BPF (little endian) hexagon - Hexagon lanai - Lanai loongarch32 - 32-bit LoongArch loongarch64 - 64-bit LoongArch mips - MIPS (32-bit big endian) mips64 - MIPS (64-bit big endian) mips64el - MIPS (64-bit little endian) mipsel - MIPS (32-bit little endian) msp430 - MSP430 [experimental] nvptx - NVIDIA PTX 32-bit nvptx64 - NVIDIA PTX 64-bit ppc32 - PowerPC 32 ppc32le - PowerPC 32 LE ppc64 - PowerPC 64 ppc64le - PowerPC 64 LE r600 - AMD GPUs HD2XXX-HD6XXX riscv32 - 32-bit RISC-V riscv64 - 64-bit RISC-V sparc - Sparc sparcel - Sparc LE sparcv9 - Sparc V9 spirv32 - SPIR-V 32-bit spirv64 - SPIR-V 64-bit systemz - SystemZ thumb - Thumb thumbeb - Thumb (big endian) ve - VE wasm32 - WebAssembly 32-bit wasm64 - WebAssembly 64-bit x86 - 32-bit X86: Pentium-Pro and above x86-64 - 64-bit X86: EM64T and AMD64 xcore - XCore Upgrading project in /home/runner/work/libdparse/libdparse/ Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.35.0/x64/ldc2-1.35.0-linux-x86_64/bin/ldc2 for x86_64. Building libdparse 0.23.2+commit.9.g614597c: building configuration [library] STAT:------ libdparse statistics ------ STAT: STAT:statistics (-before, +after) STAT:library size=3170548 libdparse.a STAT:rough build time=13s STAT: STAT: STAT:------ DCD statistics ------ STAT: { "name": "dcd", "description": "The D Completion Daemon is an auto-complete program for the D programming language", "copyright": "Copyright © 2015-2020, Brian Schott", "authors": [ "Brian Schott" ], "license": "GPL-3.0", "dependencies": { ":dsymbol": "*", "libdparse": {"path":".."}, ":common": "*", "emsi_containers": "~>0.9.0" }, "subPackages": ["dsymbol", "common"], "versions": ["built_with_dub"], "configurations": [ { "name": "library", "targetType": "library", "excludedSourceFiles": [ "src/dcd/client/*", "src/dcd/server/main.d" ] }, { "name": "client", "targetType": "executable", "targetPath": "bin/", "targetName": "dcd-client", "excludedSourceFiles": [ "src/dcd/server/*" ] }, { "name": "server", "targetType": "executable", "targetPath": "bin/", "targetName": "dcd-server", "excludedSourceFiles": [ "src/dcd/client/*" ] } ] } { "fileVersion": 1, "versions": { "dsymbol": "0.14.1", "emsi_containers": "0.9.0", "libdparse": {"path":".."}, "msgpack-d": "1.0.4", "stdx-allocator": "2.77.5" } } STAT:statistics (-before, +after) STAT:client size=1052640 bin/dcd-client STAT:server size=3110848 bin/dcd-server STAT:rough build time=63s STAT: unix:tc001: ... Pass unix:tc002: ... Pass unix:tc003: ... Pass unix:tc004: ... Pass unix:tc005: ... Pass unix:tc006: ... Pass unix:tc007: ... Pass unix:tc008: ... Pass unix:tc009: ... Pass unix:tc010: ... Pass unix:tc011: ... Pass unix:tc012: ... Pass unix:tc013: ... Pass unix:tc014: ... Pass unix:tc015: ... Pass unix:tc016: ... Pass unix:tc017: ... Pass unix:tc018: ... Pass unix:tc019: ... Pass unix:tc020: ... Pass unix:tc021: ... Pass unix:tc022: ... Pass unix:tc023: ... Pass unix:tc024: ... Pass unix:tc025: ... Pass unix:tc026: ... Pass unix:tc027: ... Pass unix:tc028: ... Pass unix:tc029: ... Pass unix:tc030: ... Pass unix:tc031: ... Pass unix:tc032: ... Pass unix:tc033: ... Pass unix:tc034: ... Pass unix:tc035: ... Pass unix:tc036: ... Pass unix:tc037: ... Pass unix:tc038: ... Pass unix:tc039: ... Pass unix:tc040: ... Pass unix:tc041: ... Pass unix:tc042: ... Pass unix:tc043: ... Pass unix:tc044: ... Pass unix:tc045: ... Pass unix:tc046: ... Pass unix:tc047: ... Pass unix:tc048: ... Pass unix:tc049: ... Pass unix:tc050: ... Pass unix:tc051: ... Pass unix:tc052: ... Pass unix:tc053: ... Pass unix:tc054: ... Pass unix:tc055: ... Pass unix:tc056: ... Pass unix:tc057: ... Pass unix:tc058: ... Pass unix:tc059: ... Pass unix:tc060: ... Pass unix:tc061: ... Pass unix:tc062: ... Pass unix:tc620: ... Pass unix:tc717: ... Pass unix:tc_access_modifiers: ... Pass unix:tc_accesschain_type: ... Pass unix:tc_anon_class: ... Pass unix:tc_anon_struct: ... Pass unix:tc_bang_op_or_template: ... Pass unix:tc_base_template_type: ... Pass unix:tc_body_var: ... Pass unix:tc_calltip_in_func: ... Pass unix:tc_casts: ... Pass unix:tc_char_dot: ... Pass unix:tc_complete_kw: ... Pass unix:tc_ctors: ... Pass unix:tc_currmod_fqn: ... Pass unix:tc_ditto_scopes: ... Pass unix:tc_empty_module: ... Pass 00000unix:tc_empty_requests: ... Pass unix:tc_erroneous_body_content: ... Pass unix:tc_extended_ditto: ... Pass unix:tc_extended_types: ... Pass unix:tc_if_auto_array: ... Pass unix:tc_if_var: ... Pass unix:tc_import_symbol_list: ... Pass unix:tc_incomplete_switch: ... Pass unix:tc_inlay_hints: ... Pass unix:tc_issue558: ... Pass unix:tc_locate_ufcs_function: ... Pass unix:tc_middle_of_utf: ... Pass unix:tc_module_scope_op: ... Pass unix:tc_named_mixin: ... Pass unix:tc_opaque_structs: ... Pass unix:tc_pointer_type_printing: ... Pass unix:tc_pointers: ... Pass unix:tc_recursive_public_import: ... Pass unix:tc_rm_import: ... Pass unix:tc_scope_mess: ... Pass unix:tc_selective_import_list: ... Pass unix:tc_super_scope: ... Pass unix:tc_template_bang_completion: ... Pass unix:tc_template_param_props: ... Pass unix:tc_traits: ... Pass unix:tc_typeof: ... Pass unix:tc_ufcs_alias_this_completion: ... Pass unix:tc_ufcs_array_type_completion: ... Pass unix:tc_ufcs_calltip_in_func: ... Pass unix:tc_ufcs_fundamental_types_completion: ... Pass unix:tc_ufcs_pointer_type_completion: ... Pass unix:tc_ufcs_string_and_string_literal_completion: ... Pass unix:tc_ufcs_struct_completion: ... Pass STAT:DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.95 STAT:DCD run_tests.sh Maximum resident set size (kbytes): 39664 STAT: STAT:short requests: (240x) STAT: min request time = 0.010ms STAT: 10th percentile = 0.135ms STAT: median time = 0.363ms STAT: 90th percentile = 0.612ms STAT: max request time = 1.503ms STAT: STAT:long requests over 10ms: (51x) STAT: min request time = 12.406ms STAT: 10th percentile = 13.927ms STAT: median time = 14.738ms STAT: 90th percentile = 16.568ms STAT: max request time = 21.695ms STAT: collect2: error: ld returned 1 exit status Error: linker exited with status 1 Error dmd failed with exit code 1. DCD BUILD FAILED std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc001: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc002: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc003: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc004: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc005: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc006: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc007: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc008: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc009: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc010: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc011: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc012: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc013: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc014: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc015: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc016: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc017: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc018: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc019: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc020: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc021: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc022: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc023: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc024: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc025: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc026: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc027: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc028: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc029: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc030: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc031: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc032: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc033: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc034: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc035: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc036: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc037: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc038: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc039: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc040: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc041: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc042: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc043: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc044: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc045: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc046: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc047: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc048: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc049: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc050: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc051: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc052: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc053: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc054: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc055: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc056: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc057: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc058: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc059: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc060: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc061: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc062: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc620: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc717: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_access_modifiers: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_accesschain_type: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_anon_class: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_anon_struct: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_bang_op_or_template: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_base_template_type: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_body_var: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_calltip_in_func: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_casts: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_char_dot: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_complete_kw: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ctors: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_currmod_fqn: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ditto_scopes: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_empty_module: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_empty_requests: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_erroneous_body_content: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_extended_ditto: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_extended_types: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_if_auto_array: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_if_var: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_import_symbol_list: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_incomplete_switch: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_inlay_hints: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_issue558: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_locate_ufcs_function: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_middle_of_utf: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_module_scope_op: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_named_mixin: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_opaque_structs: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_pointer_type_printing: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_pointers: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_recursive_public_import: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_rm_import: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_scope_mess: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_selective_import_list: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_super_scope: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_template_bang_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_template_param_props: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_traits: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_typeof: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_alias_this_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_array_type_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_calltip_in_func: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_fundamental_types_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_pointer_type_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_string_and_string_literal_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory std.socket.SocketOSException@std/socket.d(2877): Unable to connect socket: No such file or directory unix:tc_ufcs_struct_completion: ... Fail ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory Error: /tmp/generate_tests-efe5ed failed with status: 1 ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory STAT:top 5 GC sources in server: ./run_tests.sh: line 69: ../bin/dcd-server: No such file or directory head: cannot open 'profilegc.log' for reading: No such file or directory ```
WebFreak001 commented 6 months ago

add a test in the tests folder to show which issue this actually fixes

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63556f0) 84.25% compared to head (62fdaaa) 84.68%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dlang-community/libdparse/pull/512/graphs/tree.svg?width=650&height=150&src=pr&token=VHoPCaUjPZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community)](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) ```diff @@ Coverage Diff @@ ## master #512 +/- ## ========================================== + Coverage 84.25% 84.68% +0.42% ========================================== Files 11 11 Lines 8561 8565 +4 ========================================== + Hits 7213 7253 +40 + Misses 1348 1312 -36 ``` | [Files](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) | Coverage Δ | | |---|---|---| | [src/dparse/formatter.d](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community#diff-c3JjL2RwYXJzZS9mb3JtYXR0ZXIuZA==) | `50.57% <100.00%> (+2.38%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/dlang-community/libdparse/pull/512/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Last update [63556f0...62fdaaa](https://app.codecov.io/gh/dlang-community/libdparse/pull/512?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dlang-community).
zyebytevt commented 6 months ago

Where should I add tests for this? My changes solely concern the Formatter, and if I'm not mistaken there appear to be no prior tests for it at all.

WebFreak001 commented 6 months ago

ah sorry I thought this was in dfmt. In libdparse at the bottom there is a large unittest block where a bunch of code snippets are tested.

You will probably want something like

testFormatNode!(FunctionDeclaration)(q{void someFunction() => whateverWasFixed()});

if you only provide a single string it is parsed and outputted again and checked that it matches the input exactly.

zyebytevt commented 6 months ago

Alright, that should hopefully do it. Had to keep in mind various empty lines for the third check that the formatter produces, but that seems to be an issue (or intended) from before.