Closed zyebytevt closed 6 months ago
DCD BUILD FAILED
❌ dub build
of DCD has failed with these changes! Please check your changes again.
Build statistics:
------ libdparse statistics ------
statistics (-before, +after)
-library size=3163068 libdparse.a
+library size=3170548 libdparse.a
rough build time=13s
------ DCD statistics ------
statistics (-before, +after)
client size=1052640 bin/dcd-client
-server size=3110400 bin/dcd-server
+server size=3110848 bin/dcd-server
rough build time=63s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.18
-DCD run_tests.sh Maximum resident set size (kbytes): 41496
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.95
+DCD run_tests.sh Maximum resident set size (kbytes): 39664
short requests: (240x)
- min request time = 0.012ms
- 10th percentile = 0.132ms
- median time = 0.424ms
- 90th percentile = 0.707ms
- max request time = 1.520ms
+ min request time = 0.010ms
+ 10th percentile = 0.135ms
+ median time = 0.363ms
+ 90th percentile = 0.612ms
+ max request time = 1.503ms
long requests over 10ms: (51x)
- min request time = 13.219ms
- 10th percentile = 15.143ms
- median time = 16.422ms
- 90th percentile = 18.737ms
- max request time = 22.406ms
+ min request time = 12.406ms
+ 10th percentile = 13.927ms
+ median time = 14.738ms
+ 90th percentile = 16.568ms
+ max request time = 21.695ms
top 5 GC sources in server:
add a test in the tests folder to show which issue this actually fixes
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
63556f0
) 84.25% compared to head (62fdaaa
) 84.68%.
Where should I add tests for this? My changes solely concern the Formatter
, and if I'm not mistaken there appear to be no prior tests for it at all.
ah sorry I thought this was in dfmt. In libdparse
at the bottom there is a large unittest block where a bunch of code snippets are tested.
You will probably want something like
testFormatNode!(FunctionDeclaration)(q{void someFunction() => whateverWasFixed()});
if you only provide a single string it is parsed and outputted again and checked that it matches the input exactly.
Alright, that should hopefully do it. Had to keep in mind various empty lines for the third check that the formatter produces, but that seems to be an issue (or intended) from before.
Nothing major, but the comment formatting produced invalid code since the three slashes at the beginning weren't written. Additionally, a shortened function body (
=>
) now also appears in formatting.