dlang-community / setup-dlang

Github action for dlang compiler setup
MIT License
46 stars 14 forks source link

Deprecated `add-path` and `set-env` #34

Closed vladdeSV closed 4 years ago

vladdeSV commented 4 years ago

Running a workflow with this action outputs the following warnings:

Warning: The add-path command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Warning: The set-env command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

The mentioned GitHub blog post is from the 1st of October, so it is relatively recent.

Relevant raw logs
Adding '/opt/hostedtoolcache/dc/dmd-2.094.1/x64/dmd2/linux/bin64' to path
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Adding '/opt/hostedtoolcache/dc/dmd-2.094.1/x64/dmd2/linux/lib64' to library path
Warning: The `set-env` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Done
vladdeSV commented 4 years ago

I used mihails-strasuns/setup-dlang@v1.0.2.

mihails-strasuns commented 4 years ago

Can you please try the current v1 branch head? It should have been fixed with node module update, I'll make a 1.0.3 if that is indeed the case.

vladdeSV commented 4 years ago

@mihails-strasuns That did the job. Using dlang-community/setup-dlang@v1 gives no warnings.

Relevant raw logs
Adding '/opt/hostedtoolcache/dc/dmd-2.094.1/x64/dmd2/linux/bin64' to path
Adding '/opt/hostedtoolcache/dc/dmd-2.094.1/x64/dmd2/linux/lib64' to library path
Done
mihails-strasuns commented 4 years ago

Thanks for checking! I'll release 1.0.3 in a moment

mihails-strasuns commented 4 years ago

https://github.com/dlang-community/setup-dlang/releases/tag/v1.0.3