search

dlang-community / std_data_json

Phobos candidate JSON implementation.
25 stars 13 forks source link

Apply taggedalgebraic PR 61 by copypaste-inlining taggedalgebraic #51

Closed FeepingCreature closed 4 years ago

FeepingCreature commented 4 years ago

Since https://github.com/s-ludwig/taggedalgebraic/pull/61 hasn't gotten replies and is holding us up via DMD bug https://issues.dlang.org/show_bug.cgi?id=21257 , sidestep the issue by temporarily inlining taggedalgebraic with the fix applied.

This commit should be reverted once PR 61 is merged.

I'd normally advocate fixing 21257 instead, but it's beyond me, so we'd be dependent on luck wrt getting a maintainer to look at it.

Note this is taggedalgebraic master - why were we rejecting 0.12.0 to begin with?

FeepingCreature commented 4 years ago

Added a version requirement for >=2.081.0 based on CI, because ... 2.081 is more than two years old, I think that's reasonable.

FeepingCreature commented 4 years ago

Retracting this PR. I can no longer reproduce my fix. Somehow, currently I am getting a linker error in opEquals(inout) despite the fact that opEquals(inout) is not even defined.