search

dlang-tour / core

D Language online tour (https://tour.dlang.org/) and online editor (https://run.dlang.io/)
Boost Software License 1.0
117 stars 47 forks source link

Update LDC, some submodules, improve checkout #725

Closed Geod24 closed 4 years ago

Geod24 commented 5 years ago

So master have been broken for more than a month

Geod24 commented 5 years ago

Hum mir-random is still failing...

Geod24 commented 5 years ago

@wilzbach : How bad would it be if we just went ahead and disabled the sanity test for the time being ?

Geod24 commented 5 years ago

The Japanese submodule update was a shot in the dark in case some weird caching happened. The English submodule update is because it was pointing to a commit outside of master and hence the instructions to locally compile led to a conflict.

Geod24 commented 5 years ago

Waiting on https://github.com/dlang-tour/core-exec/pull/47 to see if it helps...

Geod24 commented 5 years ago

@wilzbach : Despite my efforts, this is very hard to fix. 1) I can't make it work on OSX because the Docker image assume it's built on Linux 2) It uses LDC which has a lot of annoying defaults (e.g. forces you to install gcc and gold) 3) It spawns docker inside of docker, using an old release...

The only way I could see this being fixed "properly" involves a full rewrite of the Dockerfile, but will also lead to an increase in the image size.

I've already spent much more time than I should have on this, and my goal (which was to have Korean language deployed on the official website) is nowhere near being achieved. I removing the controversial commits, and I hope you'll merge this PR, even if it does not fix everything.

I'd like to remind you that I effectively wasted many days trying to get this to work, just for a sanity check which is not even mandatory for the tour to work.

Dlang.jpeg

Geod24 commented 4 years ago

@PetarKirov : Can you review this ?

PetarKirov commented 4 years ago

Finally a green build! Unbelievable :smile: