Closed MoonlightSentinel closed 4 years ago
Another approach would be to extend IExecProvider.RunInput
to support arguments passed to the compiled binary. Then one could simply pass runArgs="--DRT-testmode=run-main"
to revert to the old behaviour.
as Dlang-Tour uses this IExecProvider according to config.yml
I'm sorry, but stupid local isn't used for the deployed tour, but the docker
config (https://github.com/dlang-tour/core/blob/master/source/exec/docker.d). The config is only the default for a local copy.
The underlying docker image is core-exec with this being its entrypoint: https://github.com/dlang-tour/core-exec/blob/master/entrypoint.sh
Another approach would be to extend IExecProvider.RunInput to support arguments passed to the compiled binary.
I think this is the better approach. It needs to be added to the API as well though, s.t. you can make use of this via REST calls:
I'm sorry, but stupid local isn't used for the deployed tour [...]
No worries, good to hear that it uses a docker container.
I think this is the better approach. It needs to be added to the API as well though, s.t. you can make use of this via REST calls:
I'll implement it
I'll implement it
Already on it:
https://github.com/dlang-tour/core-exec/pull/51 https://github.com/dlang-tour/core/pull/743
Nice
Executables build with unittests won't run main anymore even if all tests were successful. Adding the Druntime flag reverts to the old behaviour.
Hopefully this makes the public examples runnable again (as Dlang-Tour uses this
IExecProvider
according toconfig.yml
)