search

dlang-tour / core

D Language online tour (https://tour.dlang.org/) and online editor (https://run.dlang.io/)
Boost Software License 1.0
120 stars 48 forks source link

Use docker image of busybox with glibc libraries. #750

Closed looked-at-me closed 4 years ago

Geod24 commented 4 years ago

What's the issue ?

looked-at-me commented 4 years ago

The dlang-tour executable uses glibc, but busybox doesn't have it unless you specifically ask for it (which this patch does). It fixes the shorten link button, essentially.

Also the build error is caused by a change in one of the libraries used in the example source codes.

Here: https://github.com/dlang-tour/mir/pull/5

Geod24 commented 4 years ago

Thanks for taking care of this! Looks like the PR you linked also triggers one of the Vibe.d regression we've been seeing recently... Waiting for upstream to merge the fix.

looked-at-me commented 4 years ago

Well the LDC build that makes the docker image is passing. The other DMD fails seem to be related to that vibe.d regression.

wilzbach commented 4 years ago

Let's just see what happens when deployed. Thank you very much!

looked-at-me commented 4 years ago

Well the shorten buttons work as well as Gist (is a bit slow), but the link for gist gives 502 bad gateway.