search

dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

Add bpfkorea/agora and Geod24/localrest #394

Open Geod24 opened 5 years ago

Geod24 commented 5 years ago 
The former is our company's main project and uses a lot of C++ interop on POSIX.
The second uses threads, message passing and std.concurrency.

Agora actually caught regression 20022, so we'll have to wait for stable to have https://github.com/dlang/dmd/pull/10127 and for it to be merged into master before merging this.

dlang-bot commented 5 years ago

Thanks for your pull request, @Geod24!

thewilsonator commented 5 years ago

Oh, I don't have write access here, you'll have to wait fo someone else.

Geod24 commented 5 years ago

Oh it somehow tries to use master instead of the default branch setup in the repo :/

wilzbach commented 5 years ago

Oh it somehow tries to use master instead of the default branch setup in the repo :/

Yes of course. That's the main development branch. Just run merge_stable and you should be good to go.

Geod24 commented 5 years ago

Yes of course. That's the main development branch.

I was talking about the repository being tested, e.g.:


Cloning https://github.com/bpfkorea/agora (tag: master) | 1s
-- | --
  | ~> git clone -b master --depth 1 https://github.com/bpfkorea/agora bpfkorea-agora
  | Cloning into 'bpfkorea-agora'...
  | warning: Could not find remote branch master to clone.
  | fatal: Remote branch master not found in upstream origin
  | 🚨 Error: The command exited with status 128

I'm going to check how it's done for Sociomantic projects, as they don't have a master branch either.

Geod24 commented 5 years ago

Got it: as we don't have a tagged release yet, it tries to use master. So I just made it use v0.x.x which is our dev branch.

Geod24 commented 5 years ago

I need libsodium and a recent C++ compiler... Any clue how to add this @wilzbach ?

wilzbach commented 5 years ago

I need libsodium and a recent C++ compiler... Any clue how to add this @wilzbach ?

It used to be that you could just add your dependencies to the ansible files (https://github.com/dlang/ci/blob/338a692013b9889ceaf2bbc726be94e259ff9708/ansible/roles/test_deps/tasks/main.yml#L10), but since the agents are now created on the fly from an image (see e.g. https://github.com/dlang/ci/pull/311), I'm not sure whether just adding it there is enough. Re recent C++ compiler: the agents use Debian Jessie, so that might be a bit hard.

Geod24 commented 5 years ago

Re recent C++ compiler: the agents use Debian Jessie, so that might be a bit hard.

Yeah I need 6.1 and Jessie uses 4.9. So I guess this is a dead end ? If so I'll just remove agora from the list for the time being.

wilzbach commented 5 years ago

Yeah you probably have to ping Martin Nowak for a newer Buildkite image.

Geod24 commented 5 years ago

Blocked by https://github.com/dlang/ci/issues/396