search

dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

Fix dub testing on stable #406

Closed Geod24 closed 4 years ago

Geod24 commented 4 years ago

Since the script is not versioned, those kinds of errors are quite common. Using git merge-base seems like the most resilient option, as it won't break in the future.

dlang-bot commented 4 years ago

Thanks for your pull request, @Geod24!

thewilsonator commented 4 years ago

https://github.com/dlang/ci/pull/405#issuecomment-571017275

Geod24 commented 4 years ago

So much for that. git clone -b master results in a shallow commit (only 1 commit in the history), hence the git merge-base fails. Although it seems that the clone is unnecessary but I'll keep that for a later PR.