Vibe.d: Clean up and remove non-Vibe-core backend

dlang / ci

dlang CI testing pipelines

https://buildkite.com/dlang

Boost Software License 1.0

13 stars 29 forks source link

Vibe.d: Clean up and remove non-Vibe-core backend #414

Closed Geod24 closed 4 years ago

Geod24 commented 4 years ago

Those backends were deprecated, and are gone in master, so we're essentially building the same backend multiple times. Also removed a few outdated comment and re-activated a test that is fixed.

CC @s-ludwig BTW there are a few vibe-core tests in vibe-d, should they be moved over to the new repository ?

dlang-bot commented 4 years ago

Thanks for your pull request, @Geod24!

s-ludwig commented 4 years ago

@Geod24: Good point regarding the tests, I missed those. I'll remove all duplicates and add those that are only in the vibe.d repository to vibe-core. The question is then, should vibe-core be tested on Buildkite, too? With regards to resource/time use I'd think that just vibe.d should still be enough to guarantee a reasonable coverage.

Geod24 commented 4 years ago

Should be green now