dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

BuildKite: Don't use LDC *master* (but the latest tag instead) #420

Closed kinke closed 4 years ago

kinke commented 4 years ago

As a band-aid for the CI regression (due to LDC master now requiring LLVM 6+). Note that the next beta is scheduled for this evening, so someone should look into raising the installed LLVM version ASAP.

dnadlinger commented 4 years ago

Also see https://github.com/dlang/ci/pull/421.

Geod24 commented 4 years ago

ldc/intrinsics.di(54): Error: undefined identifier LLVM_version

  | ldc/intrinsics.di(54): Error: pragma LDC_intrinsic requires exactly 1 string literal parameter

Looks like a submodules / ldc mismatch ?

dlang-bot commented 4 years ago

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Geod24 commented 4 years ago

I added a commit to just use git submodule update --init instead of clone, let's see if that works...

Geod24 commented 4 years ago

Thanks!

kinke commented 4 years ago

Thank you for the submodule fix.

WalterBright commented 4 years ago

Thanks everyone for clearing up this mysterious blocker. I presume this was what was causing me problems with https://github.com/dlang/druntime/pull/3159 and https://github.com/dlang/dmd/pull/11413

WalterBright commented 4 years ago

Yep, it's cleared up now!