Fix LDC regression with new Ansible image

kinke commented 4 years ago

The LLVM 8 libs seem unusable with the used bfd linker; switch to gold.

kinke commented 4 years ago

Sadly, no change:

/usr/bin/c++   -DDMDV2 -DHAVE_SC_ARG_MAX -g  -fuse-ld=gold utils/CMakeFiles/gen_gccbuiltins.dir/gen_gccbuiltins.cpp.o  -o bin/gen_gccbuiltins  -rdynamic -lLLVMTableGen -lLLVM-8 -ldl -L/usr/lib/llvm-8/lib -ldl
/usr/bin/ld.gold: error: /usr/lib/llvm-8/lib/libLLVMTableGen.a(Main.cpp.o): invalid section group 55 refers to earlier section 2

dlang-bot commented 4 years ago

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

dnadlinger commented 4 years ago

(NB: Not an LDC bug, but an issue with the system C++ tools; the executable is C++-only. Weird!)

dlang / ci

Fix LDC regression with new Ansible image #422