dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

Re-enable unit-threaded #428

Closed atilaneves closed 4 years ago

dlang-bot commented 4 years ago

Thanks for your pull request and interest in making D better, @atilaneves! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Geod24 commented 4 years ago
~> bash
--
  | TERM environment variable not set.
atilaneves commented 4 years ago

I think the failure was caused by the CI scripts clearing the console but TERM isn't set when run from buildkite. I just pushed a new version of unit-threaded so here's hoping this passes now, especially since it being disabled allowed a regression to sneak through to dmd.

Geod24 commented 4 years ago

@atilaneves : You need to tag a new release, Buildkite doesn't use master.

atilaneves commented 4 years ago

Debugging why this fails is "fun". Googled and tried but can't reproduce a local environment with TERM not set. Except maybe a cron job?

MoonlightSentinel commented 4 years ago

Commented on the commit, your workaround does not work with set -u AFAICT

atilaneves commented 4 years ago

Commented on the commit, your workaround does not work with set -u AFAICT

Any ideas?

MoonlightSentinel commented 4 years ago

https://github.com/atilaneves/unit-threaded/commit/4213bfb9b5b06f541281e692688e81fb9090ec65#r41781457

Geod24 commented 4 years ago

I see you gave up :D