search

dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

Buildkite: Try same-named branches when cloning core repos, for PRs originating from official dlang repos #452

Open kinke opened 2 years ago

kinke commented 2 years ago

Looks alright from what I can tell - this is a PR from an official dlang repo itself, BUILDKITE_PULL_REQUEST_REPO='git://github.com/dlang/ci.git', and CI checks out the same-named DMD and druntime branches (https://github.com/dlang/dmd/pull/13593 and https://github.com/dlang/druntime/pull/3718). LDC failing is to be expected, as this breaking change affects the frontend itself.

RazvanN7 commented 2 years ago

Is the buidkite ldc failure going away after https://github.com/dlang/dmd/pull/13593 is merged?

kinke commented 2 years ago

Not really - it depends on whether Buildkite does a full or shallow git clone of dmd AFAICT. If it's a shallow clone without .git subdir, the compiler defines __VERSION__ as 2099 with that DMD PR, and enables the opEquals fix. That fix breaks older (read: all current) frontends, so LDC needs to be prepared (https://github.com/ldc-developers/ldc/pull/3910) and then the Buildkite ref bumped to master. I was thinking of doing that in a separate PR here (this PR should be green after merging, won't test the fix22717 branches anymore).