search

dlang / ci

dlang CI testing pipelines
https://buildkite.com/dlang
Boost Software License 1.0
13 stars 29 forks source link

Fix Higgs build by re-adding Python2 #482

Closed alexandrumc closed 1 year ago

alexandrumc commented 1 year ago

Higgs no longer compiles because we switched from python2 to python3 in Dockerfile. This is an attempt to fix it.

alexandrumc commented 1 year ago

My first commit (where I targeted my local agent) shows that it actually works.

Geod24 commented 1 year ago

Not interested in fixing Higgs ? Supporting Python2 is only going to add more pain in the future.

alexandrumc commented 1 year ago

Not interested in fixing Higgs ? Supporting Python2 is only going to add more pain in the future.

The docs say that it requires Python2: https://github.com/higgsjs/Higgs/blob/master/README.md?plain=1#L35. Also, on your current setup python points to the Python3 binary, so one would have to explicitly use python2 (as I did for Higgs) to actually use Python2.

Probably I could update this https://github.com/higgsjs/Higgs/blob/master/source/runtime/layout.py but I don't quite have time right now, will try to update it in the following days, so I would suggest moving on with this solution for now.

Geod24 commented 1 year ago

The docs say that it requires Python2: https://github.com/higgsjs/Higgs/blob/master/README.md?plain=1#L35. Also, on your current setup python points to the Python3 binary, so one would have to explicitly use python2 (as I did for Higgs) to actually use Python2.

That doc was written 9 years ago (https://github.com/higgsjs/Higgs/commit/017712c63d0e3ab3a395f8b6ce0e0a156d896147), 6 years before Python2 went EOL.

alexandrumc commented 1 year ago

https://github.com/higgsjs/Higgs/pull/218