search

dlang / ddox

Advanced D documentation engine
MIT License
63 stars 21 forks source link

add visual tests for ddox rendering #107

Closed MartinNowak closed 8 years ago

MartinNowak commented 9 years ago
MartinNowak commented 9 years ago

There is a small heroku app running for the uploads. https://ddox-test-uploads.herokuapp.com/

s-ludwig commented 8 years ago

Interesting! That would also be especially interesting in conjunction with custom style tests, so that unintended CSS "APi" changes get caught. How is the process for updating the reference images for intended visual changes - downloading the images off the heroku app?

MartinNowak commented 8 years ago

downloading the images off the heroku app?

Yes you can do that, in fact due to sub-pixel differences on different platforms, the ones produced locally might not match. A better place to upload pictures would make sense though, heroku fs is ephemeral (1 hour until suspend).

MartinNowak commented 8 years ago

Just made a dummy style change to show the diffing.

s-ludwig commented 8 years ago

Okay, I guess I could store those on my server, it would just need some kind of basic security mechanisms. Is it maybe possible to upload a private key to Travis for doing client-authentication?

s-ludwig commented 8 years ago

Just made a dummy style change to show the diffing.

Looks good. Of course it would be possible to go crazy with some JavaScript to enhance the UI, but I think this is already useful enough.

s-ludwig commented 8 years ago

WRT private keys, this sounds like it could be useful: https://docs.travis-ci.com/user/encryption-keys/

MartinNowak commented 8 years ago

Is it maybe possible to upload a private key to Travis for doing client-authentication?

Yes you can store them as secure variable, but those aren't available to PRs.

s-ludwig commented 8 years ago

So do PRs have a different pair of keys? Otherwise I'd just encrypt a username/password key and use HTTPS+basic auth for the upload.

MartinNowak commented 8 years ago

Yes you can store them as secure variable, but those aren't available to PRs.

A pastbin for images would be nice.

s-ludwig commented 8 years ago

Nevermind w.r.t. the secure variables, I'm reading up on it now.

s-ludwig commented 8 years ago

Okay, I'll merge it like this for now. Will be interesting to see what the syntax highlighting PR does. Sad that Travis doesn't just offer an ssh-agent with a fixed generated key, so that scp could be used.