search

dlang / dlang-bot

dlang-bot for automated bugzilla, github, and trello references
https://bot.dlang.io/
MIT License
22 stars 14 forks source link

dlang-bot is hitting a lot of 404's lately #195

Open wilzbach opened 6 years ago

wilzbach commented 6 years ago 
[github/pull_request](dlang/phobos#6370): action=opened
GET https://api.github.com/repos/dlang/phobos/pulls/6370/commits failed; Not Found 404.

Maybe dlang-bot is too fast and it just needs to wait a bit before responding to GH?

MartinNowak commented 6 years ago

Assuming that this breaks dlang-bot functionality. Quite sloppy of github to not persist all data before sending off hooks. Can we confirm that this is an actual GH issue and that waiting would help? Maybe we need some kind of a job queue that allows retry on temporary failures, though 404 is a bit tricky.

wilzbach commented 6 years ago

Can we confirm that this is an actual GH issue and that waiting would help?

I haven't looked into the logs lately, so I can't really confirm, but it doesn't appear all to often so the only explanation for these rare 404 is that GitHub uses some CDN or distributed database (maybe mongo :P) that doesn't support full consistency.

Maybe we need some kind of a job queue that allows retry on temporary failures, though 404 is a bit tricky.

We also sometimes get 401s when the API limit is exhausted, so a queue might help there too.