BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch

dlang / dlang-bot

dlang-bot for automated bugzilla, github, and trello references

https://bot.dlang.io/

MIT License

22 stars 14 forks source link

BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch #296

Open RubyTheRoobster opened 2 years ago

RubyTheRoobster commented 2 years ago

Issue #23291 was automatically marked as RESOLVED FIXED by the bot when its PR was merged, in addition to a message being posted by the bot about its being merged.

Meanwhile, for issue #23140, the bot mentioned the PR (which targeted stable) being opened, but never posted when the PR was merged, and I had to manually mark it as RESOLVED FIXED. This is clearly a bug.

CyberShadow commented 1 year ago

Yes, but unfortunately the bug is in GitHub.

Sometimes, GitHub delivers notifications for events before they "happen". Meaning, it tells the bot that something changed (e.g. a PR has been created), but when the bot asks GitHub for information about the PR, GitHub replies that no such PR exists.

We probably need to add a workaround for this, e.g. sleeping a few seconds to allow GitHub's parts to catch up with themselves.