search

dlang / dub

Package and build management system for D
MIT License
674 stars 228 forks source link

Support nonet application #1923

Closed WebFreak001 closed 2 years ago

WebFreak001 commented 4 years ago

Currently there might be issues in the library-nonet implementation like in #1910 which are not caught by the simple unittests. Running the full tests directory on a dub executable using library-nonet (vibe.d instead of curl) would prevent such issues from happening much better.

gedaiu commented 4 years ago

Can you give me an idea about what is needed to change here? I looked at the ci scripts and they look quite complex.

Geod24 commented 4 years ago

Duplicate of https://github.com/dlang/dub/issues/1558 ?

WebFreak001 commented 4 years ago

no this is an issue about adding some travis config and a new dub configuration like application-nonet because there is no targetType "executable" with nonet (no curl) in the dub.json

1558 is about using dub as a library with nonet config, but it will most likely also fix the compilation issues in there if this is fixed.

WebFreak001 commented 4 years ago

@gedaiu a configuration for application-nonet would need to be added and in dub.json and then built using the previously built dub (or manually adjust the build script but I think this is rather error-prone)

In the end it you would just change the scripts/ci/travis.sh where it runs test/run-unittest.sh to run it with the DUB environment variable pointing to the nonet application

gedaiu commented 4 years ago

I see, so in the end you want to test this configuration in the existing travis jobs. It should be easy to change..

What about semaphore-ci.sh ? Should this be changed too?

Geod24 commented 2 years ago

Fixed by https://github.com/dlang/dub/pull/2509

WebFreak001 commented 2 years ago

for the use-case of not needing curl, continued here: #2512