Closed s-ludwig closed 2 years ago
Geod24
commented
2 years ago Hum that was done in https://github.com/dlang/dub/commit/3c1c005ffa005acaa9173efe311be4b5e4464ba9 and I agree it wasn't a great idea. I'd be very happy with supporting more versions. The usage of the throw expression is, I think, more accidental than something I wanted absolutely (IOW: I wrote the code, it compiled).
s-ludwig
commented
2 years ago Regarding the compile error, I'm not sure what exactly happens here, it obviously also works for the CI jobs, but not with the Windows version of LDC that I have installed (from the standard distribution ZIP file).
s-ludwig
commented
2 years ago Warning Package maven-dubpackage not found for maven repository at http://localhost:13733/maven/release/dubpackages: Failed to download http://localhost:13733/maven/release/dubpackages/maven-dubpackage/maven-metadata.xml
Not sure what to do about this one, doesn't seem to be related to the changes.
Geod24
commented
2 years ago There's a spurious failure for this: https://github.com/dlang/dub/issues/2345
s-ludwig
commented
2 years ago Okay, all tests have passed after a re-run.
Why was it decided to drop all compiler support earlier than "ldc-latest" and "dmd-latest" (which doesn't explain why it didn't even compile on ldc-latest)? Having a buffer range of a few compiler versions greatly reduces friction during version transitions, not only in the build environment for dub itself, but also for dependencies of dub that might move slower. And IMHO using the latest shiny features, such as throw expressions in an infrastructure project like this is just utterly unnecessary. I think this really was a bad decision and should be revised, if possible. BTW, compiling with DMD 1.29.0 on Windows still produces backend errors due to some SumType.