search

dlang / dub

Package and build management system for D
MIT License
678 stars 227 forks source link

Return null instead of empty array #2492

Closed skoppe closed 2 years ago

skoppe commented 2 years ago

Silly change to get my account verified

Geod24 commented 2 years ago

Damn it I broke the nightlies again...

Geod24 commented 2 years ago

@WebFreak001 : First time contributors (people without a PR merged) need to have someone with merge access click "Approve and Run" for the CI to run. And every time they push something new, you have to click "Approve and Run" again. It's ridiculous.

WebFreak001 commented 2 years ago

that doesn't answer my question though, also the CI was already running without me doing anything here :p

Geod24 commented 2 years ago

Because I approved it.

Geod24 commented 2 years ago

that doesn't answer my question though

@skoppe has another PR which is substantial. Everytime he does a change and push, CI doesn't run, because he doesn't have a commit in master yet. Now he has a commit in master, so CI will run.

WebFreak001 commented 2 years ago

oh right that makes sense then, I thought this had something to do with meson package search somewhere explicitly requiring null, which would have been weird.