search

dlang / dub

Package and build management system for D
MIT License
678 stars 227 forks source link

Fix #813 proper #2549

Closed rikkimax closed 1 year ago

rikkimax commented 1 year ago

WIP

rikkimax commented 1 year ago

Oh no...

[INFO] Running /home/runner/work/dub/dub/test/[issue813-fixed-dependency.sh](http://issue813-fixed-dependency.sh/)...
verify that we can build sub without add-local
    Starting Performing "debug" build using dmd for x86_64.
    Building sub ~master: building configuration [library]
verify that we can build sub with add-local
             Registered package: sub (version: ~master)
    Starting Performing "debug" build using dmd for x86_64.
    Building sub ~master: building configuration [library]
             Deregistered package: sub (version: ~master)
verify that we can build main application
    Starting Performing "debug" build using dmd for x86_64.
    Building sub:sub ~master: building configuration [library]
    Building sub ~master: building configuration [library]
    Building main ~master: building configuration [application]
     Linking main

That is not what I want to see, since that is certainly reproducing the problem on Windows... wait, is this a Windows specific bug?

rikkimax commented 1 year ago 
verify that we can build sub without add-local
Performing "debug" build using dmd for x86_64.
sub ~master: building configuration "library"...
verify that we can build sub with add-local
Registered package: sub (version: ~master)
Non-optional dependency 'sub:sub' of 'sub' not found in dependency tree!?.
Deregistered package: sub (version: ~master)
verify that we can build main application
Performing "debug" build using dmd for x86_64.
sub:sub ~master: building configuration "library"...
sub ~master: building configuration "library"...
main ~master: building configuration "application"...
Linking...

Ooooo yes, something is up here @s-ludwig!

rikkimax commented 1 year ago

Okay, this is fixed in ~master, just gotta figure out what fixed it.

EDIT: something in 1.30.0, but as it is a giant refactor release it doesn't matter.

WebFreak001 commented 1 year ago

shouldn't we merge the test case for this then?

rikkimax commented 1 year ago

(Ignoring that I already deleted the branch)

My test cases were just slight changes to the ones Sonke added back in 2016 for this issue and I am worried that this could be Windows specific (as I was explaining on Discord).

Geod24 commented 1 year ago

Yeah we need to get the test-suite running on Windows...

rikkimax commented 1 year ago

Perhaps we should consider putting together a cross platform shell and distribute it with the compiler.

Good example project and would allow us easier transitioning test suites.

On Mon, Dec 12, 2022, 20:35 Mathias LANG @.***> wrote:

Yeah we need to get the test-suite running on Windows...

— Reply to this email directly, view it on GitHub https://github.com/dlang/dub/pull/2549#issuecomment-1346017506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSL4ZTXQ45WL5UY3Z3NQDWM3IVXANCNFSM6AAAAAAS22IEEQ . You are receiving this because you modified the open/close state.Message ID: @.***>