ibuclaw
commented
1 year ago I added -Wextra to GDC, but haven't had a response from @ibuclaw yet if we should or should not include it here.
-Wextra should turn on these codegen-level warnings.
extern(C++) class CPPClass { int a; }
extern(D) class DClass { int a; }
void *ptr;
void test()
{
if (&ptr == null) // Waddress
return;
if (&ptr) // Waddress
return;
auto cpptod = cast(DClass)new CPPClass; // Wcast-result
auto dtocpp = cast(CPPClass)new DClass; // Wcast-result
ifloat i;
float f = cast(float)i; // Wcast-result
}GDC emits deprecation warnings when importing deprecated modules (which makes sense I think), but this diverges from the other compilers.
I can't think of why it would converge, unless this is to do with not having a separation between deprecation and warnings.
WebFreak001
Geod24
github-actions[bot]
There was different behavior in GDC and deprecationWarnings did not perform expected results with DMD and LDC.
I added
-Wextrato GDC, but haven't had a response from @ibuclaw yet if we should or should not include it here.GDC emits deprecation warnings when importing deprecated modules (which makes sense I think), but this diverges from the other compilers. This was the initial reason why I noticed that deprecations break builds, which didn't happen with other compilers. (dub_test_root imports all modules, even if they are deprecated)
We should probably also fix
dub_test_rootsto emitdeprecated static importfor deprecated symbols, as well as handling them properly. But I think that's for another PR.