dlang / dub

Package and build management system for D
MIT License
661 stars 228 forks source link

Regression: [dependency-target] not being identified in windows #2560

Closed MrcSnm closed 6 months ago

MrcSnm commented 1 year ago

System information

Bug Description

Dub is not reading anything from dependencies-windows. If I move directx-d to "dependencies" instead of "dependencies-windows", bug is fixed

How to reproduce?

"configurations": [
        {
            "name": "default",
            "dependencies": {
                "bindbc-opengl": {"version": "~>1.0.0", "optional": true},
                "hipengine_api": {"path": "../../api"},
                "windowing" : {"path" : "../windowing"},
                "data" : {"path": "../data"},
                "image" : {"path": "../image"},
                "bind" : {"path": "../bind", "optional": true},
                "config": {"path": "../config"},
                "error": {"path": "../error"},
                "math": {"path": "../math"}
            },
            "dependencies-windows": {
                "directx-d": {"path": "../../dependencies/directx-d", "optional": true}
            },
            "versions": [
                "HipGL3",
                "GL_45",
                "GL_ARB",
                "HipGLUseVertexArray"
            ]
        },
}

Logs

import path[0] = modules\renderer\source
import path[1] = modules\bind\source
import path[2] = C:\Users\Hipreme\AppData\Local\dub\packages\bindbc-lua-0.5.1\bindbc-lua\source
import path[3] = C:\Users\Hipreme\AppData\Local\dub\packages\bindbc-loader-1.0.1\bindbc-loader\source
import path[4] = C:\Users\Hipreme\AppData\Local\dub\packages\bindbc-openal-1.0.0\bindbc-openal\source
import path[5] = C:\Users\Hipreme\AppData\Local\dub\packages\bindbc-opengl-1.0.3\bindbc-opengl\source
import path[6] = modules\error\source
import path[7] = modules\console\source
import path[8] = modules\config\source
import path[9] = modules\debugging\source
import path[10] = modules\util\source
import path[11] = modules\data\source
import path[12] = api\source
import path[13] = modules\image\source
import path[14] = C:\Users\Hipreme\AppData\Local\dub\packages\arsd-official-10.9.8\arsd-official
import path[15] = modules\math\source
import path[16] = modules\windowing\source
import path[17] = C:\D\dmd2\windows\bin\..\..\src\phobos
import path[18] = C:\D\dmd2\windows\bin\..\..\src\druntime\import
rikkimax commented 1 year ago

After talking on Discord, it appears to be a duplicate key problem. Thoughts @Geod24?

Geod24 commented 1 year ago

dependencies-windows actually only meant dependencies, and dub was ignoring the platform suffix. @MrcSnm do you get an error message, or just an ignored dependency ? It sounds like the latter, which would be a bug.

See also https://github.com/dlang/dub/issues/1049

MrcSnm commented 1 year ago

No error message. That same dub configuration was working on dub 1.28.0

Geod24 commented 6 months ago

Actually this is a duplicate of #615