dlang / dub

Package and build management system for D
MIT License
678 stars 227 forks source link

enable -preview=in, fix #2617 #2623

Closed WebFreak001 closed 10 months ago

WebFreak001 commented 1 year ago

reopening #2620

sorry for the bunch of force pushes, I just wanted to get the PR Info action to work for this, as it should summarize changing deprecations like this and should show fixed things. (building on linux)

github-actions[bot] commented 1 year ago

✅ This PR fixes following deprecations:

source/dub/internal/dyaml/node.d(2513,9): Deprecation: scope variable `this` assigned to non-scope parameter `_param_0` calling `match`
source/dub/dependency.d(917,18): Deprecation: scope variable `this` assigned to non-scope parameter `oth` calling `opEquals`
source/dub/dependency.d(920,30): Deprecation: scope variable `this` assigned to non-scope parameter `a` calling `doCmp`
source/dub/dependency.d(921,27): Deprecation: scope variable `this` assigned to non-scope parameter `b` calling `doCmp`
source/dub/dependency.d(939,26): Deprecation: scope variable `this` assigned to non-scope parameter `oth` calling `opEquals`
source/dub/internal/configy/Exceptions.d(130,34): Deprecation: reference to local variable `buffer` assigned to non-scope parameter `__anonymous_param` calling ``
source/dub/internal/configy/Exceptions.d(134,34): Deprecation: reference to local variable `buffer` assigned to non-scope parameter `__anonymous_param` calling ``
source/dub/internal/configy/Exceptions.d(248,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(250,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(283,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(286,27): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(323,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(325,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(332,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`
source/dub/internal/configy/Exceptions.d(335,31): Deprecation: `@safe` function `formatMessage` calling `formattedWrite`

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
-executable size=5524656 bin/dub
-rough build time=92s
+executable size=5455024 bin/dub
+rough build time=88s
Full build output ``` DUB version 1.30.0, built on Feb 11 2023 LDC - the LLVM D compiler (1.31.0): based on DMD v2.101.2 and LLVM 14.0.3 built with LDC - the LLVM D compiler (1.31.0) Default target: x86_64-unknown-linux-gnu Host CPU: skylake-avx512 http://dlang.org - http://wiki.dlang.org/LDC Registered Targets: aarch64 - AArch64 (little endian) aarch64_32 - AArch64 (little endian ILP32) aarch64_be - AArch64 (big endian) amdgcn - AMD GCN GPUs arm - ARM arm64 - ARM64 (little endian) arm64_32 - ARM64 (little endian ILP32) armeb - ARM (big endian) avr - Atmel AVR Microcontroller bpf - BPF (host endian) bpfeb - BPF (big endian) bpfel - BPF (little endian) hexagon - Hexagon lanai - Lanai mips - MIPS (32-bit big endian) mips64 - MIPS (64-bit big endian) mips64el - MIPS (64-bit little endian) mipsel - MIPS (32-bit little endian) msp430 - MSP430 [experimental] nvptx - NVIDIA PTX 32-bit nvptx64 - NVIDIA PTX 64-bit ppc32 - PowerPC 32 ppc32le - PowerPC 32 LE ppc64 - PowerPC 64 ppc64le - PowerPC 64 LE r600 - AMD GPUs HD2XXX-HD6XXX riscv32 - 32-bit RISC-V riscv64 - 64-bit RISC-V sparc - Sparc sparcel - Sparc LE sparcv9 - Sparc V9 systemz - SystemZ thumb - Thumb thumbeb - Thumb (big endian) ve - VE wasm32 - WebAssembly 32-bit wasm64 - WebAssembly 64-bit x86 - 32-bit X86: Pentium-Pro and above x86-64 - 64-bit X86: EM64T and AMD64 xcore - XCore Upgrading project in /home/runner/work/dub/dub/ Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.31.0/x64/ldc2-1.31.0-linux-x86_64/bin/ldc2 for x86_64. Building dub 1.32.0-beta.1+commit.16.gffd43d42: building configuration [application] Serializing composite type Flags!(BuildRequirement) which has no serializable fields Serializing composite type Flags!(BuildOption) which has no serializable fields Linking dub STAT:statistics (-before, +after) STAT:executable size=5455024 bin/dub STAT:rough build time=88s ```
WebFreak001 commented 1 year ago

from #2620:

source\dub\internal\vibecompat\core\file.d(104,39): Error: cannot use `in` parameters with `extern(Windows)` functions
source\dub\internal\vibecompat\core\file.d(104,39):        parameter `to` declared as `in` here
source\dub\internal\vibecompat\core\file.d(104,39): Error: cannot use `in` parameters with `extern(Windows)` functions
source\dub\internal\vibecompat\core\file.d(104,39):        parameter `from` declared as `in` here
Geod24 commented 1 year ago
/home/runner/work/dub/dub/source/dub/recipe/sdl.d:349: error: undefined reference to '_D3std6format__TQkTaTAyaZQtFNaNfMxAaQpZQs'
/home/runner/work/dub/dub/source/dub/recipe/sdl.d:350: error: undefined reference to '_D3std6format__TQkTaTAyaZQtFNaNfMxAaQpZQs'
/home/runner/work/dub/dub/source/dub/recipe/sdl.d:351: error: undefined reference to '_D3std6format__TQkTaTAyaZQtFNaNfMxAaQpZQs'
/home/runner/work/dub/dub/source/dub/recipe/sdl.d:380: error: undefined reference to '_D3std6format__TQkTaTAyaZQtFNaNfMxAaQpZQs'
/home/runner/work/dub/dub/source/dub/internal/utils.d:1086: error: undefined reference to '_D3std3net4curl4HTTP15onReceiveHeaderMFNdDFMxAaMxQeZvZv'

What ? :|

WebFreak001 commented 1 year ago

looks like that only happens on LDC, probably because phobos is compiled differently, causing different mangling

Geod24 commented 10 months ago

2783