Closed Geod24 closed 10 months ago
github-actions[bot]
commented
10 months ago ✅ PR OK, no changes in deprecations or warnings
Total deprecations: 11
Total warnings: 0
Build statistics:
statistics (-before, +after)
executable size=5351336 bin/dub
-rough build time=60s
+rough build time=59s
s-ludwig
commented
9 months ago Okay, this is really bad. The fix here is completely backwards and doesn't make any sense. I recognize that the add-path feature is obviously not communicated well enough, but this just makes it completely unusable. The functionality for unmanaged directories must simply stay the way it always was. It is meant to pick up your cloned working copies of projects that are for example in your "dev" folder. Nobody in their right mind would organize that folder with a doubly-nested structure including version or branch names.
s-ludwig
commented
9 months ago BTW, it was not the best move to push a change like this into the stable branch just before release, without a meaningful functional review.
Currently, we issue a warning asking people to migrate, but the migrated path is not actually recognized. It was suggested in the issue to ignore this warning for add-path. However, as add-path is a rather low-level use, I think it is better to impose the same condition for managed and unmanaged path, in order to be able to provide the same guarantees. For example, once we move to reading version from the path, we can provide the same speedups for add-path users. We can also make sure that add-path users don't have surprises when dealing with packages that expect a certain structure outside their directory, such as arsd and ae. Some tests were updated with the new path, however, as many will likely be rewritten with the new test framework, and a lot of tests are affected, not all of them were updated, providing coverage for the old and new code alike.